[5.x] Add site filter to TermsQuery #10131

arcs- · 2024-05-21T11:37:27Z

This PR adds the site filter argument on the Graphql TermsQuery. This aligns it with the EntriesQuery and GlobalSetQuery that already had it.

jasonvarga

Please add a test to TermsTest.

The equivalent behavior for entries is here:

cms/tests/Feature/GraphQL/EntriesTest.php

Lines 77 to 107 in 32300df

    
               public function it_queries_all_entries_in_a_specific_site() 
        
               { 
        
                   $this->createEntries(); 
        
                   $this->setSites([ 
        
                       'en' => ['url' => 'http://localhost/', 'locale' => 'en'], 
        
                       'fr' => ['url' => 'http://localhost/fr/', 'locale' => 'fr'], 
        
                   ]); 
        
                   Collection::find('events')->routes('/events/{slug}')->sites(['en', 'fr'])->save(); 
        
                   EntryFactory::collection('events')->locale('fr')->origin('4')->id('44')->slug('event-two')->create(); 
        
                   $query = <<<'GQL' 
        
           { 
        
               entries(site: "fr") { 
        
                   data { 
        
                       id 
        
                   } 
        
               } 
        
           } 
        
           GQL; 
        
                   $this 
        
                       ->withoutExceptionHandling() 
        
                       ->post('/graphql', ['query' => $query]) 
        
                       ->assertGqlOk() 
        
                       ->assertExactJson(['data' => ['entries' => ['data' => [ 
        
                           ['id' => '44'], 
        
                       ]]]]); 
        
               }

feat: add site filter to TermsQuery

cf3bd44

jasonvarga requested changes May 21, 2024

View reviewed changes

add test

bd40b9c

jasonvarga merged commit d2ae92c into statamic:5.x May 28, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.x] Add site filter to TermsQuery #10131

[5.x] Add site filter to TermsQuery #10131

arcs- commented May 21, 2024

jasonvarga left a comment

	public function it_queries_all_entries_in_a_specific_site()
	{
	$this->createEntries();

	$this->setSites([
	'en' => ['url' => 'http://localhost/', 'locale' => 'en'],
	'fr' => ['url' => 'http://localhost/fr/', 'locale' => 'fr'],
	]);

	Collection::find('events')->routes('/events/{slug}')->sites(['en', 'fr'])->save();

	EntryFactory::collection('events')->locale('fr')->origin('4')->id('44')->slug('event-two')->create();

	$query = <<<'GQL'
	{
	entries(site: "fr") {
	data {
	id
	}
	}
	}
	GQL;

	$this
	->withoutExceptionHandling()
	->post('/graphql', ['query' => $query])
	->assertGqlOk()
	->assertExactJson(['data' => ['entries' => ['data' => [
	['id' => '44'],
	]]]]);
	}

[5.x] Add site filter to TermsQuery #10131

[5.x] Add site filter to TermsQuery #10131

Conversation

arcs- commented May 21, 2024

jasonvarga left a comment

Choose a reason for hiding this comment